Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable to publish info, currently we publish node's function document, or node name #716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

k-okada
Copy link
Member

@k-okada k-okada commented Jul 20, 2022

No description provided.

@tkmtnt7000
Copy link
Member

キッチンデモにこのPRをいれて試してみました.2022/08/23 22:51 の Message from Fetch1075がタイトルのメールです.
docstringをつけたものは小文字,大文字になっているのは関数から引っ張ってきた名前です.
これまでにsmachで書かれたデモに最小限の変更で適用するには良さそうな気がします.

smach-kitchen-with-docstrint.mp4

@k-okada
Copy link
Member Author

k-okada commented Aug 24, 2022

@tkmtnt7000 thank you for checking,
I think DESCRIPTION/IMAGE is designed to tell users about how they think and what they do. but INFO is for developpers.
so, I think message body is

キッチンを見に行くよ
IMAGE
キッチンの様子を見たよ
IMAGE

---
INFO : <time>
INFO : <time>
.....

@tkmtnt7000
Copy link
Member

Thank you for advice.
I change smack_to_mail to display INFO for developers.

@k-okada
Copy link
Member Author

k-okada commented Aug 24, 2022

jsk-ros-pkg/jsk_robot#1568 (review)
にコメントしましたが,DESCRIPTION/IMAGE は開発者ではない人,が読むメッセージとして確認するのが良いと思います。
INFOは開発者向けでよいとおもいます。

開発者の定義はLispが読める人,そのプログラムを自分で治す可能性がある人,です。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants