[WIP] Implement the named properties object #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forces all interfaces annotated with [PrimaryGlobal] or [Global] and that supports named getter to become factories, the reasoning being that [[GetOwnProperty]] of the named properties object (which is
window.__proto__.__proto__
) needs to be able to accesswindow
, which is of course impossible whenwindow
hasn't been created yet. Thus, the caller would do roughly something like the following to makewindow
available to the [[GetOwnProperty]] hook:The implementation class only needs to implement
@@supportsPropertyName
and@@namedGet
(or only the latter if [WebIDL2JSValueAsUnsupported] is used);@@supportedPropertyNames
is not necessary since named properties object does not support property name iteration.This PR is considered finished, but DO NOT MERGE since it's very likely there still remain a significant number of bugs as the jsdom counterpart is not yet complete, and this code is essentially untested (other than the output is valid JavaScript).