[gcloud] fix double decompression when using gzip #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thuibr
changed the title
|
@jschneier what are your thoughts on this change as opposed to using |
|
@jschneier I added a test. How do I run the tests in CI? |
|
@jschneier can you merge this? |
|
@jschneier can you look at this? |
thuibr
changed the title
|
@jschneier what do I need to do to get this PR looked at and approved? |
|
@thuibr can you confirm this fixes your issue? We will also need to fix CI. |
|
@jschneier, I double checked just now that this fixes the issue. I also made a change to the test that I think fixes CI. |
|
@jschneier do you need to run the CI? |
|
@jschneier Do you mind making a release for this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
self.blob.download_to_filealready performs decompression per this StackOverflow post. Rather than attempting to decompress the gzip file a second time and receiving an error, allowself.blob.download_to_fileto decompress it.An alternative to this would be to use the
raw_download=Truekwarg forself.blob.download_to_fileif that is desirable.This closes #1456.