Add FileSystemOverwriteStorage #1252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigds
force-pushed
the
filesystemoverwrite-storage
branch
from
d0f47db to
d19266a
Compare
craigds
force-pushed
the
filesystemoverwrite-storage
branch
from
d19266a to
5112692
Compare
|
any chance of a review here? |
|
I'm happy to accept this but am a bit concerned about drift from core. As an example |
|
This one seems likely to land into upstream so going to close here. See: django/django#18020 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved implementation of #1209
Background:
This ticket is going in loops:
Refer https://code.djangoproject.com/ticket/28144
I guess django-storages apparently did once have this class, and it was removed.
Per that above ticket, Django later added a fix to make it possible to override the not-overwriting behaviour (an
OS_OPEN_FLAGSattribute)Looks like there was (a LONG time ago) some discussion about including this feature in Django: https://code.djangoproject.com/ticket/4339 (it was closed wontfix due to the trivial nature of a custom implementation)
So, that puts us back here - we need somewhere to store that custom implementation, and django-storages seems like the right project for the job...
I've added a test and some basic docs (I don't think much is required, since there's no special configuration etc, unlike the other backends)