Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Решил задачи 2 модуля - 3, 4, 5. #4

Merged
merged 3 commits into from
Dec 25, 2024

Conversation

SergeyKalabin
Copy link

No description provided.

sergeykalabin added 3 commits December 25, 2024 19:40
…ив и с ним работал и 5 задачу - если честно очень сложно пока, пошел в гости к своему другу и только он смог помочь, небольшая каша в голове
@jsru-1
Copy link
Contributor

jsru-1 commented Dec 25, 2024

Добавляю преподавателя (@ShGKme) для код-ревью.

@jsru-1 jsru-1 requested a review from ShGKme December 25, 2024 18:53
Copy link

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Принято

Comment on lines +11 to +37
const pages = [
{
id: 'meetup-id-1',
name: 'meetupId',
value: 1,
},
{
id: 'meetup-id-2',
name: 'meetupId',
value: 2,
},
{
id: 'meetup-id-3',
name: 'meetupId',
value: 3,
},
{
id: 'meetup-id-4',
name: 'meetupId',
value: 4,
},
{
id: 'meetup-id-5',
name: 'meetupId',
value: 5,
},
]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Такие данные обычно генерируют, чтобы не описывать вручную

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

При этом name здесь неизменяемое значение - его проще оставить в шаблоне. А id - вычисляется от value. Поэтому все значения можно сразу описывать в месте их использования в шаблоне.

@jsru-1 jsru-1 merged commit 79aa99e into js-tasks-ru:master Dec 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants