Выбранный митап #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Добавляю преподавателя (@ShGKme) для код-ревью. |
ShGKme
approved these changes
Dec 25, 2024
| setup() {}, | ||
| setup() { | ||
| const metupId = ref(1) | ||
| const meetup = ref({}) |
There was a problem hiding this comment.
{} (объект без полей) - некорректное начальное значение, это не частный случай данных, объекта с митапов. Отсутствие данных лучше явно описывать как null. В противном случае неудобно проверять наличие данных, и сложнее находить источник ошибки при работе с данными (например, сейчас можно обратиться к title и получить undefined вместо ошибки, но обращение к agenda[0] приведёт к ошибке. Обе ситуации неявные и не дают понять, что проблема в отсутствии митапа.
| </div> | ||
|
|
||
| <div class="meetup-selector__cover"> | ||
| <div class="meetup-cover"> | ||
| <h1 class="meetup-cover__title">Some Meetup Title</h1> | ||
| <h1 class="meetup-cover__title">{{meetup.title}}</h1> |
There was a problem hiding this comment.
Здесь всегда выводится заголовок, даже когда митапа нет и заголовок - пустая строка.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.