Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module 2 task 1 #2

Merged
merged 7 commits into from
Dec 11, 2024
Merged

module 2 task 1 #2

merged 7 commits into from
Dec 11, 2024

Conversation

Yaltaphil
Copy link
Contributor

No description provided.

@jsru-1
Copy link
Contributor

jsru-1 commented Dec 8, 2024

Добавляю преподавателя (@tadjik1) для код-ревью.

@jsru-1 jsru-1 requested a review from tadjik1 December 8, 2024 15:51
@jsru-1
Copy link
Contributor

jsru-1 commented Dec 8, 2024

Решение было обновлено, посмотрим что скажет @tadjik1

@@ -1,4 +1,4 @@
export default {
module.exports = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

спасибо! это я не досмотрел сначала

const Joi = require("joi");

@Injectable()
export class JoiValidationPipe implements PipeTransform {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ух ты, отличное использование Joi 👍

Copy link

@tadjik1 tadjik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

блестящее решение, все критичные и необходимые моменты учтены (badrequest, валидация) 💯

@jsru-1 jsru-1 merged commit 9ea03fd into js-tasks-ru:master Dec 11, 2024
1 check passed
@Yaltaphil
Copy link
Contributor Author

блестящее решение, все критичные и необходимые моменты учтены (badrequest, валидация) 💯

спасибо я старался, а joi это в статье habr был пример - попробовал сначала его (ранее joi не использовал только yup и zod ), а затем попробовал декораторы

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants