Using graceful-ncp instead of ncp

[adam-lynch]

This helps with EMFILE errors. See adam-lynch/graceful-ncp.

This is related to nwutils/nw-builder#123

[adam-lynch]

ping

[jprichardson]

I'm in favor of using graceful-fs... but I don't see the need for a new module to merge the two. Why not submit a PR to ncp to optionally use graceful-fs much like this module does?

[adam-lynch]

The maintainer is serious about "not taking any dependencies into this module".

One place where he has said it: AvianFlu/ncp#16.

[jprichardson]

Yes, I saw that. It's not necessary to take it as a dependency. See this module as an example. It's just a matter of:

try {
  fs = require("graceful-fs")
} catch (er) {
  fs = require("fs")
}

No dependency required.

[adam-lynch]

Sure, I'll try. I assumed it wouldn't be accepted.

[adam-lynch]

Forgot to post the PR here; AvianFlu/ncp#70

[traviswimer]

Another possibility that might work better if the dependency is unacceptable is to just allow fs to be passed as a parameter. In other words something like this maybe:

var gfs = require("graceful-fs");
var fs = require("fs-extra")( gfs );

I didn't actually look at the code to know if this specifically is reasonable, but it would be nice to have the option of the library of you choice through some process.

[jprichardson]

@traviswimer graceful-fs is already a part of fs-extra and has been for awhile, see: https://github.com/jprichardson/node-fs-extra/blob/master/lib/index.js#L8 The concern is that ncp, the copy module that fs-extra uses does not use graceful-fs and won't accept any dependency modules.

Either way, I think I'm going to fork ncp into fs-extra as the ncp guys have been pretty silent lately.

[jprichardson]

Done. https://github.com/jprichardson/node-fs-extra/releases/tag/0.15.0

[jprichardson]

Includes graceful-fs now as well.

[adam-lynch]

Could you clarify what impact this has? What do you mean by "io.js only"? Is this a backwards-incompatibile change? What I mean is will I have to switch to io.js everywhere my code is ran for this to work? I haven't read into io.js enough yet probably.

[jprichardson]

@adam-lynch 0.15.0 includes ncp, uses graceful-fs, patches ncp for support for io.js. You won't have to modify any of your code as it works on both node.js and io.js.

[adam-lynch]

Thanks

On Wed, 21 Jan 2015 22:52 JP Richardson [email protected] wrote:

@adam-lynch https://github.com/adam-lynch 0.15.0 includes ncp, uses
graceful-fs, patches ncp for support for io.js. You won't have to modify
any of your code as it works on both node.js and io.js.

—
Reply to this email directly or view it on GitHub
#95 (comment)
.