Fallback to description when content is not provided for JSON feed #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RSS 2 the description may contain the full text and the content can be omitted when there is not a short version available: https://cyber.harvard.edu/rss/rss.html#hrelementsOfLtitemgt However a JSON feed will not contain a `content_html` field when the content is not provided. This makes it hard to create both a JSON feed and an RSS 2 feed because providing content without a description will create a `content:encoded` field but not a `description` field in the RSS 2 feed. My solution to this is to fallback to the `item.description` when `item.content` is not provided and generating a JSON feed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RSS 2 the description may contain the full text and the content can be omitted when there is not a short version available: https://cyber.harvard.edu/rss/rss.html#hrelementsOfLtitemgt
However a JSON feed will not contain a
content_htmlfield when the content is not provided.This makes it hard to create both a JSON feed and an RSS 2 feed because providing content without a description will create a
content:encodedfield but not adescriptionfield in the RSS 2 feed.My solution to this is to fallback to the
item.descriptionwhenitem.contentis not provided and generating a JSON feed.