Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1 compatibility #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rgpublic
Copy link

Thanks for this great library which has proven to be very useful and reliable over the years. The attached pull request is necessary for PHP 8.1 compatibility. Note that this is a BC break due to next() not being able to return an item anymore, so applications will fail if they rely on this behavior. Therefore, I'd suggest considering to upgrade the major version.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@rgpublic
Copy link
Author

Perhaps I should add if you do this, then you will lose compatibility with PHP < 8.0 due to the "mixed" type not being available AFAIK. So perhaps releasing a new 2.0 version that is explicitly marked as PHP >= 8.0 is really justified.

@joshribakoff
Copy link
Owner

joshribakoff commented Jun 14, 2022

Thanks but unfortunately I don’t have time or motivation to maintain this library, I don’t use PHP anymore these days so I’m not prepared to review these changes. Please feel free to fork :) thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants