Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Reader.php #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Reader.php #13

wants to merge 2 commits into from

Conversation

steinm6
Copy link

@steinm6 steinm6 commented Dec 1, 2014

Typo on line 111. skippedlines should be skippedLines

Typo on line 111. skippedlines should be skippedLines
@joshribakoff
Copy link
Owner

Thanks, looks like it wasn't fixed in all places, so the automated tests failed:

There was 1 error:

1) ReaderTest::test_Csv_Reader_Removes_Blank_Lines

Undefined property: Csv_Reader::$skippedlines

/home/travis/build/joshribakoff/php-csv-utils/source/Csv/Reader/Abstract.php:176

/home/travis/build/joshribakoff/php-csv-utils/tests/ReaderTest.php:135

https://travis-ci.org/joshribakoff/php-csv-utils/jobs/42643925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants