Improve git root detection logic

[jesseleite]

Firstly, a quick thank you, for all your awesome work on sesh! It's a game changer for me ❤️

The problem:

The sesh README says that sesh root assumes existence of a .bare folder...

Note: This will only work if you are in a git worktree or git repository. For now, git worktrees expect a .bare folder.

Not everyone uses git worktrees this way. For example, many prefer the conventional git clone --bare [repo] project, which leaves you with a messy project folder, but this is still very common nonetheless.

I on the other hand, prefer to run git clone --bare [repo] project/.git, which stores all of the git meta in .git folder, but still creates a bare repo. This leaves me with a really clean project folder when using worktrees...

The .bare convention is cool too, but again would require different pathing logic for each situation.

A possible solution:

My proposition is to use the output of git worktree list, since git knows where the main worktree / bare repo lives...

^ As you can see, the main worktree is always listed first, no matter how you roll with git worktrees (whether that be using .git, or .bare, or doing it the messier default way.

For example, this is what you see when running git worktree list...

This PR uses git worktree list to grab that first field, for the basis of sesh root and also for the namer package used when naming sessions.

I was able to remove all --git-common-dir, --show-toplevel, and .bare checks, because those all seem to be handled well with the first field returned by git worktree list; It seems to be super consistent across all situations 🎉

Todo:

• Proof of concept
  • Using git worktree list to find root from within git worktree repos
    • Using .bare convention
    • Using .git convention
    • With standard worktree (git config/refs/etc. files at root)
  • Using git worktree list to find root from non-worktree repo subdirs
• Get working with sesh root command
• Get working with namer package
• Add test coverage

[jesseleite]

Also, as a side effect of the new implementation, the issue described in #192 seems to be solved! 🎉

Tmux + gum example using the new sesh root functionality...

[joshmedeski]

Gotta fix tests, I'll DM you and we can do some pair programming to fix it.

[joshmedeski]

When I choose a git worktree I got this result:

_bare/Users/joshmedeski/c/sesh/v1

But expected this::

sesh/v1

[joshmedeski]

Furthermore, when I call sesh root I'm getting the following output:

~/c/sesh/.bare

However, I need this to be the root so I can properly leverage the root search feature:

~/c/sesh

[joshmedeski]

I moved this to a draft for now, let me know if you want someone else to take over or have some time soon to revisit this work and finish it up, thanks!