Weights for Univariates #46
Conversation
Adding the functionality of weights in average shifted histograms for univariates
Added documentation for weights
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 84.68% 83.54% -1.14%
==========================================
Files 4 4
Lines 209 231 +22
==========================================
+ Hits 177 193 +16
- Misses 32 38 +6
☔ View full report in Codecov by Sentry. |
|
Looks cool! Give me a chance to play around with the PR, but I'd love to add this feature 👍 . @ParadaCarleton You don't need to ping me (especially within the same day as the PR!). |
|
This is a great start, but there's a few changes I'd like to see:
I think 1 is what I'd require before merging. 2 Can happen sometime later (by me, you, or anyone else). |
Changed the weights to keyword argument. Updated documentations and tests accordingly
|
I made the requested change (only |
|
I meant to remove ash(x; weight=nothing, kw...) |
- Removed functions `ashw` and `ashw!` - Integrated the weighted-ash as part of `ash` and `ash!` - Updated tests
|
I have made the changes you requested (again, only for P.S.: Sorry for having to wait so long... |
- Implement AbstractWeights - Added tests for weights, aweights, fweights, pweights - Removed weight as a keyword argument and make it a positional argument instead - Updated documentations
|
I made some modifications to the previous commit to include |
|
Looks good to me. Thanks for the PR and responding to comments! |
This PR partially addresses #23 and adds weights for univariate average-shifted histograms.
Jobs done:
ashwfor univariate weighted average-shifted histograms