-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Docker setup #50
base: master
Are you sure you want to change the base?
Conversation
I like this a lot, but a few things:
This compose file is working great though, no more wasted time copying files :) |
@alex-taxiera Good point. I reverted the changes to the readme and the local art fix I made. Do you know what the correct fix is for the local art? Is that already present in the main branch? I see some PRs open for it, but I'm unaware of what the correct fix would be. |
I opened #52 which I believe is the "best" fix based on this comment |
This PR refactors the (in my respectful opinion) shoddy Docker setup to something more practical. There's an easy Dockerless setup for people to use already. If people do want to use Docker, one can assume those people have some technical know-how already.
The old setup creates a huge Docker image by copying everything over, convoluted by adding a redundant dependency on
make
into the mix.The new setup uses Docker Compose (provided by Docker out-of-the-box nowadays) using a lightweight Nginx container instead, using volume mounting, and not reliant on
make
.