Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] remove deprecated strings #40296

Closed
wants to merge 3 commits into from

Conversation

brianteeman
Copy link
Contributor

This PR removes language strings marked for deprecation in 5.0

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

This PR removes language strings marked for deprecation in 5.0
This reverts commit 6d76cdfb4cbf54b06a18fab7b17aa8a27098e0e8.
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.0-dev labels Apr 2, 2023
@brianteeman brianteeman changed the title 5 strings [5.0] remove deprecated strings Apr 2, 2023
@brianteeman
Copy link
Contributor Author

@HLeithner there are a few more strings marked for removal in #39374 which related to build\media_source\com_users\js\admin-users-mail.es6.js but this file was put back in #39431 and marked to be removed in 5.0. Is that js still being removed in 5.0? If not then I should remove/change the language string comment

@HLeithner
Copy link
Member

did @richard67 removed the files from #39431 already in a 5.0 PR?

@richard67
Copy link
Member

did @richard67 removed the files from #39431 already in a 5.0 PR?

@HLeithner No, I haven't done that yet. Shall I do that?

@HLeithner
Copy link
Member

yes please

@richard67
Copy link
Member

@HLeithner See PR #40302 .

@richard67
Copy link
Member

I have tested this item ✅ successfully on 996c306

Code review: I can confirm that this PR covers all deprecations for 5.0 in language files which have a corresponding deprecation comment.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40296.

@HLeithner
Copy link
Member

@brianteeman since @richard67 brings this up in the other PR could you create a PR against the 5.0 branch in the manual please?

joomla/Manual#28 Add a section to the b/c incompatible file

@brianteeman
Copy link
Contributor Author

with a pr against a pr?

@HLeithner
Copy link
Member

with a pr against a pr?

it's the 5.0 branch in the manual repo

@richard67
Copy link
Member

@brianteeman since @richard67 brings this up in the other PR could you create a PR against the 5.0 branch in the manual please?

joomla/Manual#28 Add a section to the b/c incompatible file

@brianteeman Harald means the https://github.com/joomla/Manual/blob/5.0/migrations/44-50/removed-backward-incompatibility.md file.

@brianteeman
Copy link
Contributor Author

Thanks @richard67

joomla/Manual#101

@richard67
Copy link
Member

@brianteeman Now you only need to adapt the last 2 check boxes in the "Link to documentations" section of the description. The "Pull Request link for manual.joomla.org: " should be checked, and the link to joomla/Manual#101 should be added at the end, and the other checkbox below that should be unchecked.

@HLeithner HLeithner added the Removal Removes functionality label Apr 7, 2023
@@ -219,15 +219,7 @@ COM_USERS_MAIL_MASSMAIL_MAIL_TITLE="Users: Mass Mail Users"
COM_USERS_MAIL_NO_USERS_COULD_BE_FOUND_IN_THIS_GROUP="No users could be found in this group."
COM_USERS_MAIL_ONLY_YOU_COULD_BE_FOUND_IN_THIS_GROUP="You are the only user in this group."
COM_USERS_MAIL_PASSWORD_RESET_DESC="Sent to a user by the "Forgot your password?" link eg in a login form."
COM_USERS_MAIL_PASSWORD_RESET_TITLE="Users: Password Reset"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think the string below is the one deprecated not the one above this line :)

@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Aug 10, 2023
@brianteeman brianteeman closed this Sep 8, 2023
@brianteeman brianteeman deleted the 5-strings branch September 8, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators Removal Removes functionality Updates Requested Indicates that this pull request needs an update from the author and should not be tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants