add Slack reporter (from jonsamwell/flutter_gherkin#71) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshedor
commented
Jul 26, 2020
| if (step.result.result != StepExecutionResult.pass && | ||
| firstFailedStepInActiveScenario == null) { | ||
| firstFailedStepInActiveScenario = step; | ||
| for (var attachment in step.attachments) { |
There was a problem hiding this comment.
@jonsamwell I added this here to address your feedback. As this repo doesn't access FlutterWorld, it didn't make sense to include the hook that generates the screenshot. I documented it for the implementor's convenience. Do you think that example is sufficient or should it be more visible/cross-documented?
tshedor
changed the title
|
@tshedor I'm not sure this belongs in the core library tbh. Having a reliance on |
|
@jonsamwell I'll leave it up to you. This PR was moved here on your advice from the flutter_gherkin repo. Flutter has If you'd rather close this PR and not be responsible for its maintenance as part of the core, no harm no foul. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rudimentary reporter that reports test results to a Slack channel as they are generated by the driver. Failed steps are reported to Slack with a screenshot. Successful features are reported to Slack with a green checkmark and the number of scenarios that passed within the feature.
Configurable options include terminating after a minimum number of failures and threading test run reports.
(originally jonsamwell/flutter_gherkin#71)