Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.1.5 #287

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Release 3.1.5 #287

wants to merge 6 commits into from

Conversation

nafiskabbo
Copy link

@nafiskabbo nafiskabbo commented Nov 5, 2024

3.1.5

  • Bump up transcoder to 0.11.2
  • Enhancement: support pass-through audio with more than 2 channels
  • Update build.gradle
  • Update example app

It fixes the issue "#279"

@marvin-kolja
Copy link

marvin-kolja commented Nov 6, 2024

Thanks for the changes!

Just thinking:
The Transcoder library has moved the organization. Since version 0.11.0 the maven coordinates changed to io. deep media.community:transcoder-android (https://github.com/deepmedia/Transcoder/blob/main/docs/changelog.mdx#0110). Since you're upgrading to 0.11.2 do you think it would make sense to also update the coordiantes in this PR @nafiskabbo @jonataslaw?

Edit:

While they claim that "The old coordinates will still work and receive updates", I'm unsure how long it will stay like that, maybe forever, maybe not.

@jonataslaw
Copy link
Owner

It also seems to me that we should do a break version?

@nafiskabbo
Copy link
Author

We can upgrade it to latest version as it will add new features and solve some of existing bugs also. Changing to new maven coordinates require some more changes I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants