Move away from obj->isa, and wrap the workAroundMacOSXABIBreakingBug... #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…check with a diagnostic ignore (bitmasking tagged pointers is deprecated).
| if(JK_EXPECT_F(workAroundMacOSXABIBreakingBug)) { goto slowClassLookup; } | ||
| #pragma clang diagnostic push | ||
| #pragma clang diagnostic ignored "-Wdeprecated-objc-pointer-introspection" | ||
| BOOL workAroundMacOSXABIBreakingBug = (JK_EXPECT_F(((NSUInteger)object) & 0x1)) ? YES : NO; |
There was a problem hiding this comment.
odyth is right. So thank you!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
|
I have fixed this problem for latest OSes (iOS 8 and MacOS 10.10). See #158. |
|
good，i fix this problem for iphone6(arm64)，Thanks！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...check with a diagnostic ignore (bitmasking tagged pointers is deprecated).
There's likely more work to do around the ABIBreakingBug check; primarily wanted to get this up and running on iOS/Xcode5.0.1. Tested on iOS7.