Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c2cpg] Fix StackOverflowError within IncludeAutoDiscovery #5221

Merged
merged 2 commits into from
Jan 13, 2025
Merged

[c2cpg] Fix StackOverflowError within IncludeAutoDiscovery #5221

merged 2 commits into from
Jan 13, 2025

Conversation

max-leuthaeuser
Copy link
Contributor

maltek
maltek approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@maltek maltek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was confused for a bit how this fixes anything. I'd suggest to rename the wrapper with a GCC-specific workaround to something more specific.

mpollmeier
mpollmeier approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@mpollmeier mpollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlights our jungle of 'ExternalCommand' wrappers... 🥲

@max-leuthaeuser
Copy link
Contributor Author

Yeah, at least a renaming makes sense.

@max-leuthaeuser max-leuthaeuser merged commit b73c108 into master Jan 13, 2025
5 checks passed
@max-leuthaeuser max-leuthaeuser deleted the max/sen3587 branch January 13, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltek maltek maltek approved these changes

@mpollmeier mpollmeier mpollmeier approved these changes

@gacevedo gacevedo Awaiting requested review from gacevedo

@johannescoetzee johannescoetzee Awaiting requested review from johannescoetzee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-leuthaeuser @mpollmeier @maltek