[javasrc2cpg] Fix orphan local class identifiers #5216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
usedCapturescontains anouterClasslocal which exists mostly to provide type information and should not be added to the CPG. Normally this would not happen, but this caused an issue withthis()calls in constructor bodies where the constructor has anouterClassparameter which should be passed throughthis, but the REF edge was instead being created to the type-info-only local. This PR fixes this issue by correctly creating the ref edge to theouterClassparameter instead. There's definitely a more robust way to fix this, but that would probably require significantly larger changes to how capture information is stored.