Allow Partial Network Upgrades #81
Annotations
7 errors and 6 warnings
Clippy:
src/build_upgrade.rs#L359
error: this block may be rewritten with the `?` operator
--> src/build_upgrade.rs:359:2
|
359 | / if upgrade_details.relay_version.clone().is_none() {
360 | | return None
361 | | }
| |_____^ help: replace it with: `upgrade_details.relay_version.clone()?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
= note: `-D clippy::question-mark` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::question_mark)]`
|
Clippy:
src/build_upgrade.rs#L452
error: called `unwrap` on `relay_call` after checking its variant with `is_some`
--> src/build_upgrade.rs:452:20
|
451 | if relay_call.is_some() {
| ----------------------- help: try: `if let Some(..) = relay_call`
452 | batch_calls.push(relay_call.unwrap().get_kusama_call().expect("kusama call"));
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
= note: `-D clippy::unnecessary-unwrap` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_unwrap)]`
|
Clippy:
src/build_upgrade.rs#L493
error: called `unwrap` on `relay_call` after checking its variant with `is_some`
--> src/build_upgrade.rs:493:20
|
492 | if relay_call.is_some() {
| ----------------------- help: try: `if let Some(..) = relay_call`
493 | batch_calls.push(relay_call.unwrap().get_polkadot_call().expect("polkadot call"));
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
|
Clippy:
src/tests.rs#L453
error: calls to `push` immediately after creation
--> src/tests.rs:453:2
|
453 | / let mut expected_networks = Vec::new();
454 | | expected_networks
455 | | .push(VersionedNetwork { network: Network::Polkadot, version: String::from("1.2.0") });
| |_______________________________________________________________________________________________^ help: consider using the `vec![]` macro: `let expected_networks = vec![..];`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
= note: `-D clippy::vec-init-then-push` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::vec_init_then_push)]`
|
Clippy:
src/tests.rs#L466
error: calls to `push` immediately after creation
--> src/tests.rs:466:2
|
466 | / let mut expected_networks = Vec::new();
467 | | expected_networks.push(VersionedNetwork {
468 | | network: Network::PolkadotAssetHub,
469 | | version: String::from("1.2.0"),
470 | | });
| |_______^ help: consider using the `vec![]` macro: `let expected_networks = vec![..];`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
|
Clippy:
src/tests.rs#L481
error: calls to `push` immediately after creation
--> src/tests.rs:481:2
|
481 | / let mut expected_networks = Vec::new();
482 | | expected_networks
483 | | .push(VersionedNetwork { network: Network::Polkadot, version: String::from("1.2.0") });
484 | | expected_networks.push(VersionedNetwork {
... |
494 | | version: String::from("1.2.0"),
495 | | });
| |_______^ help: consider using the `vec![]` macro: `let expected_networks = vec![..];`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
|
Clippy
Clippy had exited with the 101 exit code
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Install nightly toolchain
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Install nightly toolchain
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Install nightly toolchain
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Install nightly toolchain
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Loading