Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bottom navigation & bug fix #150

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Conversation

DixitSTTL
Copy link
Contributor

Issue solved.
-Landscape mobile NavigationRail.
-Floating action button.

@joelkanyi
Copy link
Owner

Hey @DixitSTTL what was the initial issue on the app?

Also can you share a screenshot of the final app look after the fix

@DixitSTTL
Copy link
Contributor Author

Hi @joelkanyi

Navigation Bar
In mobile landscape mode, all navigation bar tab could not fit inside the panel.
"Setting tab" was out of the screen.

so I have make NavigationRail scrollable and adjustable on screen height change.

Before
setting tab was totally out of screen in mobile landscape mode.

Screenshot (27)

After
now it is scrollable & adjustable to bottom on window height increase.

Screenshot (23)
Screenshot (24)
Screenshot (25)

Copy link
Owner

@joelkanyi joelkanyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution

@joelkanyi joelkanyi merged commit a8974cc into joelkanyi:main Sep 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants