Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show artist top songs with at least one play #946

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

Maxr1998
Copy link
Collaborator

@Maxr1998 Maxr1998 commented Nov 7, 2024

Fixes the minor issue where the artist top songs section would also show songs with "0 plays".

@Chaphasilor Chaphasilor merged commit a57dc4f into jmshrv:redesign Nov 7, 2024
4 checks passed
@Maxr1998 Maxr1998 deleted the fix-top-songs branch November 7, 2024 17:09
@Chaphasilor
Copy link
Collaborator

Makes sense, thanks! I'll make sure that empty lists don't cause any issues.

@Maxr1998
Copy link
Collaborator Author

Maxr1998 commented Nov 8, 2024

Good point, I didn't think of that. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants