Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EdgeToEdge ui overlay mode on Android #940

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

pohuing
Copy link

@pohuing pohuing commented Nov 1, 2024

This addresses #917

Album view Player screen Song detail bottom sheet
Screenshot_20241101-214733 Screenshot_20241101-214738 Screenshot_20241101-214744

@Chaphasilor
Copy link
Collaborator

Hey, thanks for the PR and sorry for not getting back to you about it (or your issue) earlier!
I saw the notification and while I'm also a bit annoyed by the black bar I was to busy to get to it yet.

I'll give this a try right now!

@pohuing
Copy link
Author

pohuing commented Nov 3, 2024

All good, my issue mentioned me trying to fix this anyways. I don't have an iPhone so it would be good someone could take a look whether this change messes up the status bar in light mode on the sign in screen.

@Chaphasilor
Copy link
Collaborator

Chaphasilor commented Nov 3, 2024

Yeah that's much better, nice! I can't test iOS either, but maybe @jmshrv could take a look at some point...
I'll probably merge this either way sometime this week for the next release! Thanks again :)

PS: I'll also try to improve the alignment for the queue button's icon, that line break looks terrible with the German translation 😅
Edit: fixed in 6cd6e92

@Chaphasilor Chaphasilor linked an issue Nov 3, 2024 that may be closed by this pull request
@jmshrv
Copy link
Owner

jmshrv commented Nov 7, 2024

This works fine on iOS :D

@Chaphasilor Chaphasilor merged commit 775b1fc into jmshrv:redesign Nov 7, 2024
4 checks passed
@Chaphasilor
Copy link
Collaborator

Perfect! Happily merged :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finamp Android does not draw the app Edge to Edge
3 participants