Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same logic for playback stop events and offline listen log #936

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

Maxr1998
Copy link
Collaborator

The boolean expression we currently use for server stop events already works very well, so the same should be used while offline (in the onTrackChanged callback). I also added a logging call to the OfflineListenLogHelper for good measure.

@Chaphasilor
Copy link
Collaborator

Thanks, will take a look tomorrow!

One thing I thought about today, will the currently playing track be properly logged when going offline mid-playback? Probably yes, since it only logs when it ends (since your recent PR), right?

@Maxr1998
Copy link
Collaborator Author

Maxr1998 commented Oct 30, 2024

Yup, it should, since the check is indeed at the end. I think I even tested this once.
The same applies in the reverse case too, once you go back online the usual logging is used again (and should work, since Jellyfin won't enforce a matching start event iirc).

@Chaphasilor Chaphasilor added the hacktoberfest-accepted Issues accepted to count as a Hacktoberfest contribution label Oct 31, 2024
@Chaphasilor Chaphasilor merged commit 34cda03 into jmshrv:redesign Oct 31, 2024
4 checks passed
@Chaphasilor
Copy link
Collaborator

Awesome, thanks!

@Maxr1998 Maxr1998 deleted the offline-listen-log-tweaks branch October 31, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Issues accepted to count as a Hacktoberfest contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants