-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace blurry png logo with svg #904
Conversation
Thanks for the PR! We already have an SVG of the logo, should we just switch to using that right now? ^^ |
@Chaphasilor Switched to use an SVG, Keeping the image commit in the PR for now (looks like the image is used in other places too. I can switch the other places to use the SVG in another PR). Or I can make it apart of this one, thoughts? |
Looking in the code it looks like there is only two other locations the image is used, the settings page and the drawer. |
I'm a fan of SVG, if we can use it in more places that would be even nicer. |
@Chaphasilor Added the last two pages to the PR, I have never had any real issues with SVG's on any of Flutter's supported platforms. |
Got it. Is there any particular reason for creating a new SVG? Was the existing one in a wrong location or had too much padding? |
@Chaphasilor I did that because I wanted to keep everything imported assets in images (since you guys don't seem to use the assets folder for any app assets, confused me a little bit. Should really be the other way around). |
Ah yeah that tracks. I have no idea why it was done that way, but I'm open to restructuring things if that makes more sense! Applies to the entire project, if there's something odd that we could do better, we should do that :) |
@Chaphasilor We could do that in a later pr. But I think this PR is good. |
Sounds good. Let's do it like that. Thanks for the PR! |
Upped the resolution to the same as the Jellyfin icon in the same folder.
Might be a good idea to switch to use the SVG instead of an PNG.