Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: login screens side padding #903

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

edeuss
Copy link

@edeuss edeuss commented Sep 26, 2024

Fixes the cramped feeling on the page change by moving the padding to the SingleChildScrollView's.

Fixes the cramped feeling on the page change.
@Chaphasilor
Copy link
Collaborator

Thanks for the PR! I just took a look but honestly can't tell a difference on my phone (Asus Zenfone 10). Even took screenshots for side-by-side comparisons.
Would you mind also sharing screenshots and letting me know which device you're using? :D

@edeuss
Copy link
Author

edeuss commented Sep 26, 2024

@Chaphasilor it's only a visual difference on the transition between pages. The embedded navigator uses the whole width instead of just part of the screen.

I can add a comparison video if needed.

@Chaphasilor
Copy link
Collaborator

Ahh, it's the transition! I see it now :D
Yeah that's much better. My original plan was to make the Finamp icon a hero widget that morphs and shrinks to the top after the first page, but that didn't work out for some reason. But the swapped padding looks much better for sure!
Thanks, merging this ^^

@Chaphasilor Chaphasilor merged commit 6de6008 into jmshrv:redesign Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants