Code

[Redesign] Downloads Storage Rewrite#568

Code

Merged

Chaphasilor merged 90 commits intojmshrv:redesignjmshrv/finamp:redesignfrom Komodo5197:main-downloads-reworkKomodo5197/finamp:main-downloads-reworkCopy head branch name to clipboardFeb 20, 2024

+14,781-6,606

Commits

Commits on Dec 16, 2023

• Added isar dependancy.

  Komodo5197

  committed
  e938395

  Copy full SHA for e938395

Commits on Dec 17, 2023

• Created initial Isar version of the download_helper.

  Komodo5197

  committed
  a2bb6ff

  Copy full SHA for a2bb6ff

Commits on Dec 18, 2023

• Isar download storage now works. Can add, delete, and playback.

  Komodo5197

  committed
  e5b0a68

  Copy full SHA for e5b0a68

Commits on Dec 19, 2023

• Most browsing tasks work now. Initial migration code.

  Komodo5197

  committed
  2444d93

  Copy full SHA for 2444d93

Commits on Dec 20, 2023

• Switched to background_downloader. Fully removed downloads_helper. Album/Playlist ordering now works.

  Komodo5197

  committed
  0d98815

  Copy full SHA for 0d98815

• Got numbers on downloads screen working. Got migration mostly functional.

  Komodo5197

  committed
  4d5ee16

  Copy full SHA for 4d5ee16

• Fix ios build.

  Komodo5197

  committed
  b015c33

  Copy full SHA for b015c33

• Merge branch 'main' of https://github.com/Komodo5197/finamp into main-downloads-rework

  Show description for 642fa0c
  Komodo5197

  committed
  642fa0c

  Copy full SHA for 642fa0c

Commits on Dec 21, 2023

• Addressed various TODOs.

  Komodo5197

  committed
  0a2b55a

  Copy full SHA for 0a2b55a

• Fixed getting collectionInfo.

  Komodo5197

  committed
  00a1b16

  Copy full SHA for 00a1b16

Commits on Dec 22, 2023

• Minor fixes.

  Komodo5197

  committed
  1bfea88

  Copy full SHA for 1bfea88

Commits on Dec 23, 2023

• Minor fixes.

  Komodo5197

  committed
  db142f5

  Copy full SHA for db142f5

• Merge remote-tracking branch 'upstream/redesign' into main-downloads-rework

  Show description for b934a86
  Komodo5197

  committed
  b934a86

  Copy full SHA for b934a86

• Merged into redesign. Needs more integration work.

  Komodo5197

  committed
  5e4960a

  Copy full SHA for 5e4960a

Commits on Dec 24, 2023

• Improved metadata API. Added implementation of saving all songs for partial albums, currently broken.

  Komodo5197

  committed
  e8b4c7f

  Copy full SHA for e8b4c7f

Commits on Dec 25, 2023

• Improved download/delete buttons and statusing. Got greyed-out songs in albums working properly. Added require wifi switch.

  Komodo5197

  committed
  b303dc0

  Copy full SHA for b303dc0

Commits on Dec 27, 2023

• Switched to using info links instead of info types. This complicates sync logic but reduces metadata store size and simplifies interface to get downloads.

  Komodo5197

  committed
  d7d6419

  Copy full SHA for d7d6419

Commits on Dec 28, 2023

• Changed download error screen into active downloads screen.

  Komodo5197

  committed
  06e26cd

  Copy full SHA for 06e26cd

Commits on Dec 30, 2023

• Upgraded dependancies. Got external download locations working, hopefully as well as they did before.

  Komodo5197

  committed
  7afa5c8

  Copy full SHA for 7afa5c8

Commits on Dec 31, 2023

• Fixed missing download completions. Added download library buttons. Added filter to show only complete downloads. Tested performing large downloads. Tweaked some UIs. Minor bug fixes. Altered store…

  Show description for 97522b7
  Komodo5197

  committed
  97522b7

  Copy full SHA for 97522b7

Commits on Jan 1, 2024

• Added secondary isar collection for download task data. Added background_downloader database implementation backed by that collection. Added background_downloader taskQueue implementation backed by…

  Show description for 2ba8813
  Komodo5197

  committed
  2ba8813

  Copy full SHA for 2ba8813

Commits on Jan 2, 2024

• Added filtering by library to downloads display. Download BaseItemDto should now update on resync to show latest metadata.

  Komodo5197

  committed
  0dd08a9

  Copy full SHA for 0dd08a9

• Fixed migration breaking. Fixed artists library filtering.

  Komodo5197

  committed
  c0fb4aa

  Copy full SHA for c0fb4aa

Commits on Jan 4, 2024

• Various minor fixes. Added a bunch of comments.

  Komodo5197

  committed
  1a6c0f5

  Copy full SHA for 1a6c0f5

• Merge branch 'redesign' of https://github.com/jmshrv/finamp into main-downloads-rework

  Show description for e08d2e5
  Komodo5197

  committed
  e08d2e5

  Copy full SHA for e08d2e5

• Merged latest redesign changes.

  Komodo5197

  committed
  f925264

  Copy full SHA for f925264

Commits on Jan 5, 2024

• Allowed offline deletes. Added download settings screen with configurable max concurrent downloads. Fixed global snackbar error function. Items with a null viewId now show according to a setting. F…

  Show description for 7d86016
  Komodo5197

  committed
  7d86016

  Copy full SHA for 7d86016

Commits on Jan 6, 2024

• Added offline artist stuff. Created Isar queue for syncs to match the deletes one. Fixed download button showing syn when offline. Added additional sync tuning setting. Added capability to download…

  Show description for 0770114
  Komodo5197

  committed
  0770114

  Copy full SHA for 0770114

• Improved downloads overview screen with syncing node count and song/image count updating. Added TODO for another light mode bug. Hopefully fixed items failing to rerun _syncDelete in delete buffer.

  Komodo5197

  committed
  12da8da

  Copy full SHA for 12da8da

Commits on Jan 7, 2024

• Attempted to improve performance by reducing unneeded deserialization.

  Komodo5197

  committed
  495420f

  Copy full SHA for 495420f

Commits on Jan 8, 2024

• Various tweaks to hopefully improve performance and clean up some possible stuck states. Switched to using MediaSources in BaseItemDto instead of seperate, reduced dedicated getPlaybackInfo calls.

  Komodo5197

  committed
  9b98386

  Copy full SHA for 9b98386

Commits on Jan 10, 2024

• Removed some throttling. Reduced database writes. Fixed a scenario that could result in items stuck running.

  Komodo5197

  committed
  e8ebb1e

  Copy full SHA for e8ebb1e

Commits on Jan 11, 2024

• Switched database writes to synchronous. Messed with throttling. Delayed starting any downloads until sync completes.

  Komodo5197

  committed
  ed26b1b

  Copy full SHA for ed26b1b

Commits on Jan 12, 2024

• Moved some methods from isar_downloads to isar_downloads_backend. Improved sync and downloads behaviour when encountering connection issues.

  Komodo5197

  committed
  036bce8

  Copy full SHA for 036bce8

Commits on Jan 13, 2024

• Allowed falling back from blurhashes to imageIds - untested. Added setting to prefer quick syncs, which skip completed songs/albums which are unlikley to have changed. Added setting to automaticall…

  Show description for b2290fc
  Komodo5197

  committed
  b2290fc

  Copy full SHA for b2290fc

Commits on Jan 14, 2024

• Improved item filesize display. Fixed sync error handling and retries. Fixed download BaseItemDto updating.

  Komodo5197

  committed
  5be8295

  Copy full SHA for 5be8295

Commits on Jan 15, 2024

• Threw some more finampCollection types in. Playlists and favorites automatically trigger a sync when changed. Messed with throttling more. Added library lookup for songs/albums in playlists/favorites.

  Komodo5197

  committed
  6ca63b7

  Copy full SHA for 6ca63b7

Commits on Jan 16, 2024

• Fixed light mode color issues. Fixed syncing while offline caching connection error results. Improved user feedback for sync errors.

  Komodo5197

  committed
  549cd5f

  Copy full SHA for 549cd5f

Commits on Jan 17, 2024

• Show requiring item in tooltip on incidental download button. Block downloads while syncing. Do not progress sync items towards failure on SocketErrors, matching treatment of downloads. Do not atte…

  Show description for 62ba887
  Komodo5197

  committed
  62ba887

  Copy full SHA for 62ba887

Commits on Jan 18, 2024

• Added a way to localize names of finampCollections like favorites. Added collection state refreshing during sync/delete if it might have changed. Fixed childCount sometimes ending up as null in dow…

  Show description for c758ae6
  Komodo5197

  committed
  c758ae6

  Copy full SHA for c758ae6

Commits on Jan 19, 2024

• Moved getItems into worker isolate. Moved user store to Isar to assist with this. Fixed item count tracking during download repairs. Upgraded dependencies.

  Komodo5197

  committed
  833ed63

  Copy full SHA for 833ed63

Commits on Jan 20, 2024

• Tweaked throttling a bit. Added downloads repair indicator.

  Komodo5197

  committed
  7f441a2

  Copy full SHA for 7f441a2

Commits on Jan 22, 2024

• Switched background_downloader to pull wifi github branch instead of pubdev stable. Switched to using global requireWifi setting.

  Komodo5197

  committed
  9b295ff

  Copy full SHA for 9b295ff

Commits on Jan 23, 2024

• Merge branch 'redesign' into pr/Komodo5197/568

  Chaphasilor

  committed
  0ed1d5d

  Copy full SHA for 0ed1d5d

Commits on Jan 24, 2024

• Added mention of low-priority pause setting to background pause notice.

  Komodo5197

  committed
  3e1f118

  Copy full SHA for 3e1f118

Commits on Jan 25, 2024

• Removed max concurrent download limit on iOS.

  Komodo5197

  committed
  3eec2ad

  Copy full SHA for 3eec2ad

• Added persistent logging to file.

  Komodo5197

  committed
  e9873ee

  Copy full SHA for e9873ee

Commits on Jan 26, 2024

• Disabled logging to file.

  Komodo5197

  committed
  69ff2c6

  Copy full SHA for 69ff2c6

• Merge branch 'redesign' of https://github.com/jmshrv/finamp into main-downloads-rework

  Show description for 040ad03
  Komodo5197

  committed
  040ad03

  Copy full SHA for 040ad03

• Merged latest redesign and cleaned up issues.

  Komodo5197

  committed
  3e2ae73

  Copy full SHA for 3e2ae73

• Improved offline sort order.

  Komodo5197

  committed
  ee6fe98

  Copy full SHA for ee6fe98

• Brand new throttling strategy. Fixed bug with music screen refresh. Reduced minSDK.

  Komodo5197

  committed
  a1179f1

  Copy full SHA for a1179f1

Commits on Jan 27, 2024

• Merge branch 'redesign' of https://github.com/jmshrv/finamp into main-downloads-rework

  Show description for 2e2d7b2
  Komodo5197

  committed
  2e2d7b2

  Copy full SHA for 2e2d7b2

• Correctly show playing downloaded songs.

  Komodo5197

  committed
  9a34fe6

  Copy full SHA for 9a34fe6

Commits on Jan 28, 2024

• Re-enabled logging to file. Tweaked sync throttling.

  Komodo5197

  committed
  7702f2f

  Copy full SHA for 7702f2f

• Cache current user data.

  Komodo5197

  committed
  4ed4495

  Copy full SHA for 4ed4495

• Merge branch 'redesign' of https://github.com/jmshrv/finamp into main-downloads-rework

  Show description for 1920a6f
  Komodo5197

  committed
  1920a6f

  Copy full SHA for 1920a6f

• Enabled offline functionality on new long press go to artist.

  Komodo5197

  committed
  6a28e66

  Copy full SHA for 6a28e66

Commits on Feb 5, 2024

• Handle paused downloads better. Delay startup for download queue initialization. Added more logging.

  Komodo5197

  committed
  bbce8d1

  Copy full SHA for bbce8d1

Commits on Feb 6, 2024

• Avoid changing item path if not in notdownloaded state.

  Komodo5197

  committed
  2055a2f

  Copy full SHA for 2055a2f

• Merge branch 'redesign' of https://github.com/jmshrv/finamp into main-downloads-rework

  Show description for 71f3a14
  Komodo5197

  committed
  71f3a14

  Copy full SHA for 71f3a14

Commits on Feb 7, 2024

• Corrected errors with merge. Cleaned up authorization headers. Ignore cancelled updates on downloads.

  Komodo5197

  committed
  458738d

  Copy full SHA for 458738d

Commits on Feb 9, 2024

• Added transcoded downloads. This is mostly just a port of the code in jmshrv#496 into the new downloads system.

  Komodo5197

  committed
  84c21a5

  Copy full SHA for 84c21a5

• Merge branch 'redesign' of https://github.com/jmshrv/finamp into main-downloads-rework

  Show description for c2511f4
  Komodo5197

  committed
  c2511f4

  Copy full SHA for c2511f4

Commits on Feb 10, 2024

• Download settings are now properly updated by syncs so that items don't use settings from the info parent that created them.

  Komodo5197

  committed
  b579f50

  Copy full SHA for b579f50

• Merge branch 'redesign' of https://github.com/jmshrv/finamp into main-downloads-rework

  Show description for d3243aa
  Komodo5197

  committed
  d3243aa

  Copy full SHA for d3243aa

• Merge fix.

  Komodo5197

  committed
  127e0c1

  Copy full SHA for 127e0c1

• reduce padding of DownloadedItems list expansion tiles

  Chaphasilor

  committed
  7443fe0

  Copy full SHA for 7443fe0

Commits on Feb 11, 2024

• Fixed transcode settings propogation issues caused by use of a single download profile field. Added setting to auto-update qualities.

  Komodo5197

  committed
  7d336f0

  Copy full SHA for 7d336f0

• Merge branch 'main-downloads-rework' of https://github.com/Komodo5197/finamp into main-downloads-rework

  Komodo5197

  committed
  3fe5fff

  Copy full SHA for 3fe5fff

• Downloads screen padding tweak.

  Komodo5197

  committed
  d7e4de4

  Copy full SHA for d7e4de4

• Merge branch 'redesign' of https://github.com/jmshrv/finamp into main-downloads-rework

  Show description for 6931024
  Komodo5197

  committed
  6931024

  Copy full SHA for 6931024

• Merge cleanup.

  Komodo5197

  committed
  caea382

  Copy full SHA for caea382

• Minor UI fixes.

  Komodo5197

  committed
  27465cf

  Copy full SHA for 27465cf

• update active downloads button icon

  Chaphasilor

  committed
  75f57ce

  Copy full SHA for 75f57ce

• Fixed possible issue where multiple download locations could result in pointless redownloads. Allowed items which need redownload but were complete to be played if a sync has not occured due to bei…

  Show description for 43e4e7b
  Komodo5197

  committed
  43e4e7b

  Copy full SHA for 43e4e7b

• Merge branch 'redesign' of https://github.com/jmshrv/finamp into main-downloads-rework

  Show description for 8472202
  Komodo5197

  committed
  8472202

  Copy full SHA for 8472202

• Merge fixes.

  Komodo5197

  committed
  1def01d

  Copy full SHA for 1def01d

Commits on Feb 14, 2024

• Merge branch 'redesign' of https://github.com/jmshrv/finamp into main-downloads-rework

  Show description for 32ecb1b
  Komodo5197

  committed
  32ecb1b

  Copy full SHA for 32ecb1b

• Updated background_downloader to stable.

  Komodo5197

  committed
  7ca0f29

  Copy full SHA for 7ca0f29

Commits on Feb 15, 2024

• Merge branch 'redesign' of https://github.com/jmshrv/finamp into main-downloads-rework

  Show description for d0b539e
  Komodo5197

  committed
  d0b539e

  Copy full SHA for d0b539e

• Got extendbody working without cutting things off. Added shadow to increase clarity of now-playing bar. Added setting to disable now-playing bar floating and have it take up the full width.

  Komodo5197

  committed
  59d9ccd

  Copy full SHA for 59d9ccd

• Removed rectangular playing bar setting.

  Komodo5197

  committed
  659fafa

  Copy full SHA for 659fafa

Commits on Feb 16, 2024

• Merge branch 'redesign' of https://github.com/jmshrv/finamp into main-downloads-rework

  Show description for 95fa529
  Komodo5197

  committed
  95fa529

  Copy full SHA for 95fa529

• Merge fixes. Upgraded gradle+dependancies after switch to flutter 3.19.

  Komodo5197

  committed
  116e699

  Copy full SHA for 116e699

Commits on Feb 17, 2024

• code review fixes. Fixed some bugs with offline sorting.

  Komodo5197

  committed
  255d2a7

  Copy full SHA for 255d2a7

Commits on Feb 18, 2024

• Code review fixes. Copied playlist ordering code for albums.

  Komodo5197

  committed
  7c80734

  Copy full SHA for 7c80734

• Code review fixes.

  Komodo5197

  committed
  62b4df4

  Copy full SHA for 62b4df4

Commits on Feb 20, 2024

• Code review fixes.

  Komodo5197

  committed
  eaa9d80

  Copy full SHA for eaa9d80

• Exclude Application Support from backups

  jmshrv

  committed
  b07aeca

  Copy full SHA for b07aeca