Transcoded Downloads #496
Closed
Transcoded Downloads #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that some bad defaults had to be filled in (TODO: RESETs) and the download button doesn't actually download right now 🙃)
|
Looks like this will still be a draft, since not specifying a coded will default to We'll be able to look into this again once jellyfin/jellyfin#9192 lands. |
|
If I'm not mistaken these changes are now live on 11.8.11/11.8.12: |
Komodo5197
added a commit
to Komodo5197/finamp
that referenced
this pull request
Feb 9, 2024
…mshrv#496 into the new downloads system.
|
Superseded by #568 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to download transcoded files. OPUS is used, as it is both the best lossy audio compression format, and the OGG container doesn't have any weird skip-back-to-the-start bits when writing, which Jellyfin really doesn't handle, as discussed in the issue.
Because iOS doesn't support OGG/OPUS, this feature will initially be Android-only. Ideally, I'd be able to request CAF/OPUS from Jellyfin, but until jellyfin/jellyfin#9192 is released, this will not be possible, as Jellyfin will only consider the container when transcoding. AAC transcoding may be possible when jellyfin/jellyfin#9249 is released, but if I remember correctly I still had weird issues.
Mostly closes #215