Add deletion of albums and songs

[Y0ngg4n]

This PR Adds simple deletion of already downloaded albums and songs

[jmshrv]

Thanks for this :)

I've just added a push that makes items actually disappear when deleting, but there are a few issues before this is merged:

• The rest of the downloads screen doesn't update (such as the overview at the top, file sizes etc
• When deleting an album in offline mode, the album still shows in the album screen, which causes an error when opened as the album no longer exists

Both could be solved by doing some state management with Riverpod. For the 2nd one, this would mean hooking up the album list to use a central source of albums from Riverpod, which would be a pretty big task. I don't mind doing this, as it would also help with other issues like deleting albums in offline mode from the album screen (which I've disabled for the same reason).

[Y0ngg4n]

Hi thanks for your review. Sure would be nice if i could get some help from you and learn fron your project 🙂

Yes i have already seen that the list does not update caused by statelesswidget. But do not know how you handle states via hive. Quick side question wouldnt it be better to use isar?

[jmshrv]

Finamp gets the list of albums with the JellyfinApiHelper class, which simply returns once without any sort of live updating. Currently, downloaded songs are stored in Hive databases, as at the time Isar was still in development. #213 will replace this janky system of Hive databases with an Isar database which should make stuff much easier. For now, we can either:

• Add a provider that handles getting the albums and allows different bits of the app to modify the list
• Rework JellyfinApiHelper to return a listener on the database. I'd like to more cleanly separate online and offline mode, so maybe I'll consider this then.

[jmshrv]

Fixes #160

[Y0ngg4n]

Ok thank you for the explanation. So what do we have to do with this PR now?

[jmshrv]

I'll probably go with the stream option as it would be much easier than using providers, although I might change my mind mid-implementation as it would cause a lot of useless StreamBuilders in the code.

[Y0ngg4n]

Ok sounds good

[arthurlutz]

Looking forward to this feature. Do you need help testing it out ?

[Y0ngg4n]

No i have to first implement the missing parts. But i am currently short on time.

[Y0ngg4n]

@jmshrv i have tested it now and it seems to work just fine. anything we need to do here or can we just merge?

[jmshrv]

I'll merge this for now, the other improvements can come later

[Y0ngg4n]

@jmshrv thank you :)

[Y0ngg4n]

@jmshrv could we push out a new release?

[jmshrv]

Yeah, I'll make a new one as discussed in #371