-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show all/more album artists on album screen and tap them to go their page #284
Show all/more album artists on album screen and tap them to go their page #284
Conversation
@rom4nik can you resolve the conflicts? |
fixed the conflict, but can't really test it. How do you specify multiple artists for an album? In the web UI I can only add multiple album artists to a song, but when editing the metadata of an album there's no field to set the album artists... |
Perhaps it would be enough to edit some song's albumArtists, lock it, then force rescan/metadata refresh on the whole album? If not, then I suppose editing tags in song file then reimporting would help. |
It's not possible to lock the album artist field, it just gets overwritten on rescan 🙃 Everything seems to be working fine, but I noticed that in the album list only one of the artists is shown. While that behavior is identical to Jellyfin web, I believe it would be better to show all artists in the album list as well. I'll go ahead and implement that change... |
If anyone could take a quick look at this to confirm that it works and I didn't break anything else that would be great! |
Merged, thanks a ton! 😁 |
Follow-up to #284, fix edge cases
@Chaphasilor you are a genius :) |
- re-implements part of #284
Fixes #280. Extracted code generating
separatedArtistTextSpans
on player screen and reused it on album page for tappable artists.