Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all/more album artists on album screen and tap them to go their page #284

Merged
merged 6 commits into from
Nov 28, 2023

Conversation

rom4nik
Copy link
Contributor

@rom4nik rom4nik commented Jul 20, 2022

Fixes #280. Extracted code generating separatedArtistTextSpans on player screen and reused it on album page for tappable artists.
Screenshot_20220721-013035_Finamp

@Y0ngg4n
Copy link
Contributor

Y0ngg4n commented Jun 18, 2023

@rom4nik can you resolve the conflicts?

@Chaphasilor
Copy link
Collaborator

fixed the conflict, but can't really test it. How do you specify multiple artists for an album? In the web UI I can only add multiple album artists to a song, but when editing the metadata of an album there's no field to set the album artists...
Am I missing something?

@rom4nik
Copy link
Contributor Author

rom4nik commented Nov 26, 2023

https://github.com/jellyfin/jellyfin/blob/099632f37e559c1aad4944fb328600a242679988/MediaBrowser.Providers/Music/AlbumMetadataService.cs#L89

Perhaps it would be enough to edit some song's albumArtists, lock it, then force rescan/metadata refresh on the whole album? If not, then I suppose editing tags in song file then reimporting would help.

@Chaphasilor
Copy link
Collaborator

It's not possible to lock the album artist field, it just gets overwritten on rescan 🙃
But I managed to copy a file, update the tags and then scan it like you suggested. (Side note: Jellyfin doesn't extract artists from the "contributing artists" tag?).

Everything seems to be working fine, but I noticed that in the album list only one of the artists is shown. While that behavior is identical to Jellyfin web, I believe it would be better to show all artists in the album list as well. I'll go ahead and implement that change...

@Chaphasilor
Copy link
Collaborator

If anyone could take a quick look at this to confirm that it works and I didn't break anything else that would be great!
Otherwise I'll merge this in tomorrow :)

@Chaphasilor Chaphasilor self-assigned this Nov 26, 2023
@Chaphasilor Chaphasilor merged commit 299163b into jmshrv:main Nov 28, 2023
2 checks passed
@Chaphasilor
Copy link
Collaborator

Merged, thanks a ton! 😁

Chaphasilor added a commit that referenced this pull request Nov 28, 2023
@rom4nik rom4nik deleted the albumscreen-show-more-artists branch November 29, 2023 01:30
@Y0ngg4n
Copy link
Contributor

Y0ngg4n commented Dec 3, 2023

@Chaphasilor you are a genius :)

Chaphasilor added a commit that referenced this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Click on Artist Name from Album View
3 participants