Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When shuffle is pressed, shuffling items list before sending it to audioService #229

Conversation

faizzzzz
Copy link
Contributor

@faizzzzz faizzzzz commented May 9, 2022

This should fix this issue: #61

Seems like the audio service only shuffles next songs that are in the queue and not existing ones. Shuffling the list before hand ensures that the first song gets shuffled as well.

…dioService so that it does not always start from the first song.
@jmshrv
Copy link
Owner

jmshrv commented May 11, 2022

Thanks for the PR, while this technically solves the problem, I don't think this is an acceptable solution because if the user disables shuffling, the resulting queue will still be shuffled. This is really an issue with the audio package I'm using, so we'll have to wait for a fix there (or submit a fix ourselves lol). I'll post the relevant issue in #61. Thanks again for your input, I really should have fixed this by now 🙃

@jmshrv jmshrv closed this May 11, 2022
@faizzzzz
Copy link
Contributor Author

Got it, thanks for your input.

@faizzzzz faizzzzz deleted the fix/issues/61/ShuffleStartsFromFirstSong branch May 11, 2022 19:31
@dburanen
Copy link

dburanen commented Jun 1, 2022

The current flow to go random on an album or playlist is to click "shuffle", then click "next song".

Maybe rather than wait on the other person's audioService and rather than shuffle the queue before sending to audioService for reasons you stated, is there a way Finamp could send it to the audioService, and then just automatically go "next song"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants