Skip to content

Commit

Permalink
Merge pull request #112 from jmkoni/add-hover-text
Browse files Browse the repository at this point in the history
adds hover text next to column titles
  • Loading branch information
jmkoni authored Jul 25, 2019
2 parents 8c43638 + 901db03 commit 6d3d5fd
Show file tree
Hide file tree
Showing 5 changed files with 52 additions and 14 deletions.
15 changes: 12 additions & 3 deletions app/views/courses/_list.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,18 @@
<th scope="col"><%= filterrific_sorting_link(@filterrific, :number) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :department) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :school) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :avg_rating) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :avg_difficulty) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :avg_work) %></th>
<th scope="col">
<%= filterrific_sorting_link(@filterrific, :avg_rating) %>
<i title="1 - bad, 10 - great, relevant to each individual students' experience" class="fal fa-question-circle"></i>
</th>
<th scope="col">
<%= filterrific_sorting_link(@filterrific, :avg_difficulty) %>
<i title="1 - easy, 10 - difficult, based on individual students' perceptions" class="fal fa-question-circle"></i>
</th>
<th scope="col">
<%= filterrific_sorting_link(@filterrific, :avg_work) %>
<i title="in hours/week" class="fal fa-question-circle"></i>
</th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :avg_grade) %></th>
<th scope="col" colspan="3"></th>
</tr>
Expand Down
15 changes: 12 additions & 3 deletions app/views/departments/_list.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,18 @@
<th scope="col"><%= filterrific_sorting_link(@filterrific, :department) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :short_name) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :school) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :avg_rating) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :avg_difficulty) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :avg_work) %></th>
<th scope="col">
<%= filterrific_sorting_link(@filterrific, :avg_rating) %>
<i title="1 - bad, 10 - great, relevant to each individual students' experience" class="fal fa-question-circle"></i>
</th>
<th scope="col">
<%= filterrific_sorting_link(@filterrific, :avg_difficulty) %>
<i title="1 - easy, 10 - difficult, based on individual students' perceptions" class="fal fa-question-circle"></i>
</th>
<th scope="col">
<%= filterrific_sorting_link(@filterrific, :avg_work) %>
<i title="in hours/week" class="fal fa-question-circle"></i>
</th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :avg_grade) %></th>
<th scope="col" colspan="3"></th>
</tr>
Expand Down
2 changes: 2 additions & 0 deletions app/views/layouts/application.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
<%= csrf_meta_tags %>
<%= csp_meta_tag %>

<link rel="stylesheet" href="https://pro.fontawesome.com/releases/v5.9.0/css/all.css" integrity="sha384-vlOMx0hKjUCl4WzuhIhSNZSm2yQCaf0mOU1hEDK/iztH3gU4v5NMmJln9273A6Jz" crossorigin="anonymous" />

<%= stylesheet_link_tag 'application', media: 'all', 'data-turbolinks-track': 'reload' %>
<%= javascript_include_tag 'application', 'data-turbolinks-track': 'reload' %>
</head>
Expand Down
19 changes: 14 additions & 5 deletions app/views/reviews/_list.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,18 @@
<th scope="col"><%= filterrific_sorting_link(@filterrific, :course) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :user) %></th>
<th scope="col">Notes</th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :work_required) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :difficulty) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :rating) %></th>
<th scope="col">
<%= filterrific_sorting_link(@filterrific, :rating) %>
<i title="1 - bad, 10 - great, relevant to each individual students' experience" class="fal fa-question-circle"></i>
</th>
<th scope="col">
<%= filterrific_sorting_link(@filterrific, :difficulty) %>
<i title="1 - easy, 10 - difficult, based on individual students' perceptions" class="fal fa-question-circle"></i>
</th>
<th scope="col">
<%= filterrific_sorting_link(@filterrific, :work_required) %>
<i title="in hours/week" class="fal fa-question-circle"></i>
</th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :experience_with_topic) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :grade) %></th>
<th scope="col">Year</th>
Expand All @@ -42,9 +51,9 @@
<td scope="row"><%= link_to "#{review.course.name} (#{review.course.full_number})", school_department_course_path(school_id: review.course.department.school.id, department_id: review.course.department.id, id: review.course.id) %></td>
<td class="user truncate"><div><%= review.user.uuid %></div></td>
<td class="notes truncate"><div><%= link_to 'Full Notes', school_department_course_review_path(school_id: review.course.department.school.id, department_id: review.course.department.id, course_id: review.course_id, id: review.id) %><%= ": " + review.notes %></div></td>
<td><%= review.work_required %></td>
<td><%= review.difficulty %></td>
<td><%= review.rating %></td>
<td><%= review.difficulty %></td>
<td><%= review.work_required %></td>
<td><%= review.experience_with_topic %></td>
<td><%= review.display_grade %></td>
<td><%= review.year %></td>
Expand Down
15 changes: 12 additions & 3 deletions app/views/schools/_list.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,18 @@
<tr>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :name) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :short_name) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :avg_rating) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :avg_difficulty) %></th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :avg_work) %></th>
<th scope="col">
<%= filterrific_sorting_link(@filterrific, :avg_rating) %>
<i title="1 - bad, 10 - great, relevant to each individual students' experience" class="fal fa-question-circle"></i>
</th>
<th scope="col">
<%= filterrific_sorting_link(@filterrific, :avg_difficulty) %>
<i title="1 - easy, 10 - difficult, based on individual students' perceptions" class="fal fa-question-circle"></i>
</th>
<th scope="col">
<%= filterrific_sorting_link(@filterrific, :avg_work) %>
<i title="in hours/week" class="fal fa-question-circle"></i>
</th>
<th scope="col"><%= filterrific_sorting_link(@filterrific, :avg_grade) %></th>
<th scope="col" colspan="2"></th>
</tr>
Expand Down

0 comments on commit 6d3d5fd

Please sign in to comment.