Fix SyntaxErrorException throwing ValueError in PHP 8 (#72)

Co-authored-by: Graham Campbell <[email protected]>
jmespath · Jun 14, 2021 · 9b87907 · 9b87907
1 parent 14fe6ef
commit 9b87907
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/SyntaxErrorException.php b/src/SyntaxErrorException.php
@@ -17,7 +17,7 @@ public function __construct(
         $expression
     ) {
         $message = "Syntax error at character {$token['pos']}\n"
-            . $expression . "\n" . str_repeat(' ', $token['pos']) . "^\n";
+            . $expression . "\n" . str_repeat(' ', max($token['pos'], 0)) . "^\n";
         $message .= !is_array($expectedTypesOrMessage)
             ? $expectedTypesOrMessage
             : $this->createTokenMessage($token, $expectedTypesOrMessage);

diff --git a/tests/ParserTest.php b/tests/ParserTest.php
@@ -48,4 +48,24 @@ public function testHandlesEmptyExpressions()
     {
         (new Parser(new Lexer()))->parse('');
     }
+
+    /**
+     * @dataProvider invalidExpressionProvider
+     * @expectedException \JmesPath\SyntaxErrorException
+     * @expectedExceptionMessag Syntax error at character 0
+     */
+    public function testHandlesInvalidExpressions($expr)
+    {
+        (new Parser(new Lexer()))->parse($expr);
+    }
+
+    public function invalidExpressionProvider()
+    {
+        return [
+            ['='],
+            ['<'],
+            ['>'],
+            ['|']
+        ];
+    }
 }