Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xlsx mention from the xlrd section #1074

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Remove xlsx mention from the xlrd section #1074

merged 2 commits into from
Jun 14, 2024

Conversation

xmo-odoo
Copy link
Contributor

xlrd removed xlsx support with the 2.0 release (https://xlrd.readthedocs.io/en/latest/changes.html), from 2.0 onwards it only supports the legacy binary file formats.

xlrd removed xlsx support with the 2.0 release (https://xlrd.readthedocs.io/en/latest/changes.html), from 2.0 onwards it only supports the legacy binary file formats.
@jmcnamara
Copy link
Owner

Thanks for that. The section being updated is intended as a direct quote from the xlrd docs so it should be modified to reflect that.

Or the xlrd section could be dropped altogether. I'll think about that.

@xmo-odoo
Copy link
Contributor Author

Thanks for that. The section being updated is intended as a direct quote from the xlrd docs so it should be modified to reflect that.

It's pretty much the blurb that's on python-excel:

This package is for reading data and formatting information from older Excel files (ie: .xls)

(I copied the wording from xlwt so that makes sense)

Or the xlrd section could be dropped altogether. I'll think about that.

I think keeping the section makes sense: xlwt is used to write to legacy excel files and xlrd to read from them. So if you're dealing with legacy excel files, you need either or both.

@jmcnamara
Copy link
Owner

It's pretty much the blurb that's on python-excel

But that isn't the blurb in the link in the docs:

xlrd is a library for reading data and formatting information from Excel files in the historical .xls format.

@xmo-odoo
Copy link
Contributor Author

Fair enough, there you go.

Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jmcnamara jmcnamara merged commit 02d27d4 into jmcnamara:main Jun 14, 2024
1 check passed
@jmcnamara
Copy link
Owner

Merged. Thanks.

@xmo-odoo xmo-odoo deleted the patch-1 branch June 14, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants