This repository has been archived by the owner on Dec 4, 2018. It is now read-only.
CURLOPT_INTERFACE setup breaks on proxy setup #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this. I'll have a look and merge the request appropriately. |
| @@ -168,7 +168,8 @@ class EpiOAuth | |||
| curl_setopt($ch, CURLOPT_ENCODING, ''); | |||
| if($this->followLocation) | |||
| curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true); | |||
| if(isset($_SERVER ['SERVER_ADDR']) && !empty($_SERVER['SERVER_ADDR']) && $_SERVER['SERVER_ADDR'] != '127.0.0.1') | |||
| if(isset($_SERVER ['SERVER_ADDR']) && !empty($_SERVER['SERVER_ADDR']) && | |||
| !preg_match('/^(|10\.127\.|192\.168\.|172\.(16|17|18|19|20|21|22|23|24|25|26|27|28|29|30|31)\.)/', $_SERVER['SERVER_ADDR'])) | |||
There was a problem hiding this comment.
This line has the regexp messed up, needs a fix.
| @@ -168,7 +168,8 @@ class EpiOAuth | |||
| curl_setopt($ch, CURLOPT_ENCODING, ''); | |||
| if($this->followLocation) | |||
| curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true); | |||
| if(isset($_SERVER ['SERVER_ADDR']) && !empty($_SERVER['SERVER_ADDR']) && $_SERVER['SERVER_ADDR'] != '127.0.0.1') | |||
| if(isset($_SERVER ['SERVER_ADDR']) && !empty($_SERVER['SERVER_ADDR']) && | |||
| !preg_match('/^(10\.|127\.|192\.168\.|172\.(16|17|18|19|20|21|22|23|24|25|26|27|28|29|30|31)\.)/', $_SERVER['SERVER_ADDR'])) | |||
|
We spent several days trying to find out what the problem was when this lib didn't work in our production environment, but worked everything else. This turned out to be the issue - it was forcing curl to use the wrong network interface when receiving traffic from our load balancer. |
|
@zemaj Thanks for posting a follow up. We should merge this in. I've been terribly busy with other things and there's another PR which adds support for the 1.1 version of the API. Once the unit tests for that are done I'll merge this in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear authors!
We recently changed our network layout and had a complaint from one of our users, thet EpiTwitter wasn't working any more. As we found out, EpiOAuth tries to determine the interface address from the SERVER_ADDR as requested in your Issue #26. Unfortunately this breaks, if the hosting provider has a proxy setup and uses a different network interface for user communication as for proxy-webhost communication.
We have added a small patch to exclude the private address ranges as per RFC 1918. This is fixed in our issue #1. This is not a fool-proof fix, so you should add a switch to turn this funcionality on if somebody absolutely needs it. Otherwise the sysop should configure routing, so you don't need to touch interface binding.
Yours sincerely
Janos Pasztor
DotRoll Ltd.