Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typos, and make user input clear #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ While you can certainly tweak this example to send directly from a short code, y
#### Configure the Twilio SMS Activity

1. Open /public/config.json and:
2. Replace applicationExtensionKey for the value you got from step 8 in configuring your package in Marketing Cloud
2. Replace applicationExtensionKey for the Unique Key value you got from step 8 in configuring your package in Marketing Cloud. Line 33
3. Replace [your-app-URL] with the domain for your specific heroku app:
- https://YOUR-APP-URL.herokuapp.com/journeybuilder/execute
- https://YOUR-APP-URL.herokuapp.com/publish
- https://YOUR-APP-URL.herokuapp.com/validate
- https://YOUR-APP-URL.herokuapp.com/stop
- https://YOUR-APP-URL.herokuapp.com/save
- https://YOUR-APP-URL.herokuapp.com/journeybuilder/publish
- https://YOUR-APP-URL.herokuapp.com/journeybuilder/validate
- https://YOUR-APP-URL.herokuapp.com/journeybuilder/stop
- https://YOUR-APP-URL.herokuapp.com/journeybuilder/save
4. Open public/js/customActivity.js and
5. Replace {{Contact.Attribute.TwilioV1.TwilioNumber}} with the correct data extension and column name that will be used to reference the TO phone number.
5. Replace {{Contact.Attribute.[Data Extension Name].[ColumnName]}} with the correct data extension and column name that will be used to reference the TO phone number.
- {{Contact.Attribute.YOUR-DATA-EXTENSION-NAME.YOUR-PHONE-NUMBER-COLUMN}}
- This is something that is typically customized when setting up Marketing Cloud but is needed in order for Twilio to understand WHO the message needs to be sent to.

Expand All @@ -82,7 +82,8 @@ If you want, the Account SID, auth token even the Messaging Service SID can be h
#### Testing Twilio SMS Activity

1. Login into Marketing Cloud and navigate to Journey Builder and create a new Journey.
2. You should be able to the Twilio SMS custom activity and drag it into the canvas
2. Create an attribute group to connect your Data Exention to the contact model. You can chnange the code to find the DataExtensionKey dynamically so that this doesn't have to be done.
2. You should be able to see the Twilio SMS custom activity and drag it into the canvas
3. Click into the activity and fill out the Account SID, Auth Token, Messaging Service SID and the body for your SMS/MMS message.
4. Better yet, test out 5 different variations of your SMS message to optimize campaign performance(optional):

Expand Down
12 changes: 6 additions & 6 deletions public/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
}
],
"outArguments": [],
"url": "https://twilio-sfmc.herokuapp.com/journeybuilder/execute",
"url": "https://YOUR-APP-URL.herokuapp.com/journeybuilder/execute",
"verb": "POST",
"body": "",
"format": "json",
Expand All @@ -30,33 +30,33 @@
}
},
"configurationArguments": {
"applicationExtensionKey": "e962d1d4-8b07-4e76-89be-ecd1f1423b6d",
"applicationExtensionKey": "[Replace with your Application Extension Key from Marketing Cloud See Previous Step 8]",
"save": {
"url": "https://twilio-sfmc.herokuapp.com/save",
"url": "https://YOUR-APP-URL.herokuapp.com/journeybuilder/save",
"verb": "POST",
"body": "",
"format": "json",
"useJwt": false,
"timeout": 2000
},
"publish": {
"url": "https://twilio-sfmc.herokuapp.com/publish",
"url": "https://YOUR-APP-URL.herokuapp.com/journeybuilder/publish",
"verb": "POST",
"body": "",
"format": "json",
"useJwt": false,
"timeout": 2000
},
"validate": {
"url": "https://twilio-sfmc.herokuapp.com/validate",
"url": "https://YOUR-APP-URL.herokuapp.com/journeybuilder/validate",
"verb": "POST",
"body": "",
"format": "json",
"useJwt": false,
"timeout": 2000
},
"stop": {
"url": "https://twilio-sfmc.herokuapp.com/stop",
"url": "https://YOUR-APP-URL.herokuapp.com/journeybuilder/stop",
"verb": "POST",
"body": "",
"format": "json",
Expand Down
2 changes: 1 addition & 1 deletion public/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ <h2>Create a Twilio SMS message:</h2>
<hr>
<div class="form-group">
<div><label for="messageBody">Create message body:</label></div>
<input class="form-control" id="messageBody" type="text" name="messageBody" value="">
<input class="form-control" id="messageBody" type="text" max-length="320" name="messageBody" placeholder="Type your Message Here" value="">
</div>
<div class="form-group">
<div><label for="messagingService">Messaging Service SID:</label></div>
Expand Down
2 changes: 1 addition & 1 deletion public/js/customActivity.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ define([
"authToken": authToken,
"messagingService": messagingService,
"body": body,
"to": "{{Contact.Attribute.TwilioV1.TwilioNumber}}" //<----This should map to your data extension name and phone number column
"to": "{{Contact.Attribute.[Data Extension Name].[ColumnName]}}" //<----This should map to your data extension name and phone number column
}];

payload['metaData'].isConfigured = true;
Expand Down
1 change: 1 addition & 0 deletions routes/activity.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ function logData(req) {
console.log("protocol: " + req.protocol);
console.log("secure: " + req.secure);
console.log("originalUrl: " + req.originalUrl);
console.log("DEID:" +req.eventDefinitionKey);
}

/*
Expand Down