array: Add array_get_item_test #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test checks if array items are *false* dropped. If they aren't (try removing `plist.false_drop = true` from the `array_get_item` function) the test panics, because the items are being freed. It shouldn't happen and we must be able to get items as long as the array exists.
|
That is super interesting behavior. Thank you for writing these tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test checks if array items are false dropped. If they aren't (try removing
plist.false_drop = truefrom thearray_get_itemfunction) the test panics, because the items are being freed. It shouldn't happen and we must be able toget items as long as the array exists.