date: Implement date methods #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a date the original library expects one to pass the number of seconds since 01/01/2001 (Mac Epoch). Since it's not obvious and we're quite used to standart Unix Timestamps instead, these methods automatically convert dates to Mac Epoch format (just like the `plist` rust library does). Both `set_date_val` method and `set_random_date` test currently panics with an assertion failure due to a [`libplist` bug](libimobiledevice/libplist#264).
|
Beautiful, thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
new_date,get_date_valandset_date_valmethods.When creating a date the original library expects one to pass the number of seconds since 01/01/2001 (Mac Epoch). Since it's not obvious and we're quite used to standard Unix Timestamps instead, these methods automatically convert dates to Mac Epoch format (just like the
plistRust library does).Both
set_date_valmethod andset_random_datetest currently panics with an assertion failure due to alibplistbug.