ref(TPC) Move all the utility functions to TPCUtils. #2599
Conversation
jallamsetty1
force-pushed
the
ref-tpc
branch
from
be70784
to
aac1deb
Compare
jallamsetty1
force-pushed
the
ref-tpc
branch
from
aac1deb
to
7de84c8
Compare
| const VIDEO_CODECS = [ CodecMimeType.AV1, CodecMimeType.H264, CodecMimeType.VP8, CodecMimeType.VP9 ]; | ||
|
|
||
| /** | ||
| * Handles track related operations on TraceablePeerConnection when browser is | ||
| * running in unified plan mode. | ||
| * Handles all the utility functions for the TraceablePeerConnection class, like calculating the encoding parameters, |
There was a problem hiding this comment.
Moving things out of TPC but to a single place doesn't really move the needle much, does it? It's still one entity with too much in it. Granted, TPC will be slimmer.
Is this a stepping stone for a further split in more narrow focused parts? I really like what you did with the quality controllers!
| */ | ||
| export class TPCUtils { | ||
| /** | ||
| * Creates a new instance for a given TraceablePeerConnection | ||
| * | ||
| * @param peerconnection - the tpc instance for which we have utility functions. | ||
| */ | ||
| constructor(peerconnection) { | ||
| constructor(peerconnection, options) { |
There was a problem hiding this comment.
Make options default to {}, it will help you later.
| } | ||
|
|
||
| const sdp = this.pc.remoteDescription?.sdp; | ||
| const defaultCodec = CodecMimeType.VP8; |
| if (this.pc.usesCodecSelectionAPI() && rtpSender) { | ||
| const { codecs } = rtpSender.getParameters(); | ||
|
|
||
| return codecs[0].mimeType.split('/')[1].toLowerCase(); |
There was a problem hiding this comment.
Is there a chance the codec list is empty?
| const { codec } = mLine.rtp.find(rtp => rtp.payload === Number(payload)); | ||
|
|
||
| if (codec) { | ||
| return Object.values(CodecMimeType).find(value => value === codec.toLowerCase()); |
There was a problem hiding this comment.
Is there a chance we don't find it?
| } | ||
| }); | ||
|
|
||
| return new RTCSessionDescription({ |
| @@ -35,7 +35,7 @@ describe('TPCUtils', () => { | |||
|
|
|||
| it('sort ssrcs associated with all FID ssrc-groups', () => { | |||
| const pc = new MockPeerConnection(); | |||
| const tpcUtils = new TPCUtils(pc); | |||
| const tpcUtils = new TPCUtils(pc, { }); | |||
There was a problem hiding this comment.
If you use a default, we don't need to pass the weird empty object.
|
|
||
| try { | ||
| transceiver = this.peerconnection.addTransceiver(mediaStreamTrack, transceiverInit); | ||
| } catch (error) { |
There was a problem hiding this comment.
Suggestion: make this function async so you don't need to do this, execptions will reject the promsie already.
| // peerconnection on chrome in unified-plan. It is ok to ignore and not report the error here since the | ||
| // action that triggers 'addTrack' (like unmute) will also configure the encodings and set bitrates after that. | ||
| if (!parameters?.encodings?.length) { | ||
| return Promise.resolve(); |
| let mungedDescription = description; | ||
|
|
||
| this.trace('RTCSessionDescription::preTransform', dumpSDP(description)); | ||
| mungedDescription = this.tpcUtils.mungeOpus(description); |
There was a problem hiding this comment.
Each of these operations re-parses the SDP. Since we are refactoring, doesn't it make sense to parse it in this functiom, and pass the transform object along, so each of the tpcUtils functions can apply transformations, and then after all of them, re-generate the SDP?
Move all utility functions to TPCUtils that include
Move all functions that call RTCPeerConnection APIs directly back to TPC.