Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2ee) increases the number of unencrypted bytes for key and non-key frames to accomodate the VP9 descriptor #2011

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

fix(e2ee) increases the number of unencrypted bytes for key and non-key frames to accomodate the VP9 descriptor #2011

wants to merge 2 commits into from
+72 −14

Conversation

tmoldovan8x8
Copy link
Contributor

No description provided.

saghul
saghul reviewed May 23, 2022
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do this per media type please, and only do the header.

@saghul saghul marked this pull request as draft June 10, 2022 09:53
@fippo
Copy link
Member

fippo commented Jul 6, 2022

the problem with is that determining the codec type is a tad complicated.
You get the payload type but in a worker you can't easily access the SDP and hence can't figure out the codec (mime type).
I have a long standing TODO to add that to the metadata too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmoldovan8x8 @fippo @saghul