feat(ui) move room info from tv to remote #1031
Conversation
mihhu
force-pushed
the
cleanup-spot-view
branch
2 times, most recently
from
1f8b4f5
to
33aa39d
Compare
| @@ -4,9 +4,6 @@ import PropTypes from 'prop-types'; | |||
| import React from 'react'; | |||
| import { connect } from 'react-redux'; | |||
|
|
|||
|
|
|||
| import { JoinInfo } from './../components'; | |||
There was a problem hiding this comment.
Is this component used elsewhere? If not, please kill it.
There was a problem hiding this comment.
It's still used on the /tv page
Ohh sorry, I'll add the code too, any suggestion for the UX? I would've said another pipe next to the domain/room, but it's already packed as it is. Maybe on the line below in all caps and in a bolder font?
|
Something like this maybe, with both the sharing domain and code next to the spot room name? |
|
Do we need both URLs?i think just the one at the top is enough no? |
mihhu
force-pushed
the
cleanup-spot-view
branch
from
33aa39d
to
eb2f70b
Compare
How about this? |
I'd drop the name of the room from under the meeting name, since it's already at the top. LGTM otherwise! |
mihhu
force-pushed
the
cleanup-spot-view
branch
from
eb2f70b
to
30a5a07
Compare
No description provided.