Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove the sentry and agafua-syslog runtime dependencies. #392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bgrozev
Copy link
Member

@bgrozev bgrozev commented Dec 17, 2021

This is to stop shipping non-essential jars and reduce potential exposure to vulnerabilities. Setting up sentry requires setting an environment variable (and potentially more changes?), so it should be easy to adapt to also include the sentry jar in the classpath.

cc @saghul @sapkra

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #392 (e9c956e) into master (a2399b9) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #392      +/-   ##
============================================
+ Coverage     23.32%   23.34%   +0.01%     
+ Complexity      291      290       -1     
============================================
  Files            62       62              
  Lines          5440     5440              
  Branches        742      742              
============================================
+ Hits           1269     1270       +1     
  Misses         3953     3953              
+ Partials        218      217       -1     
Impacted Files Coverage Δ
...in/java/org/jitsi/jigasi/sounds/PlaybackQueue.java 54.38% <0.00%> (-1.76%) ⬇️
.../jitsi/jigasi/sounds/SoundNotificationManager.java 29.62% <0.00%> (-0.83%) ⬇️
src/main/java/org/jitsi/jigasi/JvbConference.java 45.33% <0.00%> (+0.29%) ⬆️
.../main/java/org/jitsi/jigasi/SipGatewaySession.java 50.00% <0.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2399b9...e9c956e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant