Merge pull request #405 from jhipster/sonarissues

Sonar: fix some issues
jhipster · Aug 20, 2023 · 2393ad6 · 2393ad6
2 parents acaf4f1 + 543dc69
commit 2393ad6
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 9 deletions.
diff --git a/src/main/java/io/github/jhipster/online/config/WebConfigurer.java b/src/main/java/io/github/jhipster/online/config/WebConfigurer.java
@@ -23,7 +23,6 @@
 import java.io.File;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Paths;
-import java.util.EnumSet;
 import javax.servlet.*;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -33,12 +32,10 @@
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.core.env.Environment;
-import org.springframework.core.env.Profiles;
 import org.springframework.util.CollectionUtils;
 import org.springframework.web.cors.CorsConfiguration;
 import org.springframework.web.cors.UrlBasedCorsConfigurationSource;
 import org.springframework.web.filter.CorsFilter;
-import tech.jhipster.config.JHipsterConstants;
 import tech.jhipster.config.JHipsterProperties;
 
 /**

diff --git a/src/main/java/io/github/jhipster/online/domain/SubGenEvent.java b/src/main/java/io/github/jhipster/online/domain/SubGenEvent.java
@@ -23,7 +23,6 @@
 import io.github.jhipster.online.domain.interfaces.CompleteDate;
 import java.io.Serializable;
 import java.time.Instant;
-import java.util.Date;
 import java.util.Objects;
 import javax.persistence.*;
 import org.hibernate.annotations.Cache;

diff --git a/src/main/webapp/app/account/password/password-strength-bar.component.ts b/src/main/webapp/app/account/password/password-strength-bar.component.ts
@@ -44,7 +44,7 @@ export class PasswordStrengthBarComponent {
     const regex = /[$-/:-?{-~!"^_`[\]]/g; // "
     const lowerLetters = /[a-z]+/.test(p);
     const upperLetters = /[A-Z]+/.test(p);
-    const numbers = /[0-9]+/.test(p);
+    const numbers = /\d+/.test(p);
     const symbols = regex.test(p);
 
     const flags = [lowerLetters, upperLetters, numbers, symbols];

diff --git a/src/main/webapp/app/admin/audits/audits.component.ts b/src/main/webapp/app/admin/audits/audits.component.ts
@@ -123,6 +123,6 @@ export class AuditsComponent implements OnInit {
 
   private onSuccess(audits: Audit[] | null, headers: HttpHeaders): void {
     this.totalItems = Number(headers.get('X-Total-Count'));
-    this.audits = audits || [];
+    this.audits = audits ?? [];
   }
 }
diff --git a/src/main/webapp/app/admin/metrics/metrics.component.ts b/src/main/webapp/app/admin/metrics/metrics.component.ts
@@ -48,10 +48,10 @@ export class MetricsComponent implements OnInit {
   }
 
   metricsKeyExists(key: MetricsKey): boolean {
-    return this.metrics && this.metrics[key];
+    return this?.metrics && this.metrics[key];
   }
 
   metricsKeyExistsAndObjectNotEmpty(key: MetricsKey): boolean {
-    return this.metrics && this.metrics[key] && JSON.stringify(this.metrics[key]) !== '{}';
+    return this?.metrics && this.metrics[key] && JSON.stringify(this.metrics[key]) !== '{}';
   }
 }
diff --git a/src/main/webapp/app/layouts/footer/footer.component.html b/src/main/webapp/app/layouts/footer/footer.component.html
@@ -38,7 +38,7 @@
                         <fa-icon [icon]="'bug'"></fa-icon>
                         Submit a bug report
                     </a> |
-                    Powered by <img src="../../../content/images/gcloud-logo.svg" height="92" width="92">
+                    Powered by <img src="../../../content/images/gcloud-logo.svg" alt="Google Cloud" height="92" width="92">
                 </div>
             </div>
         </div>