Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows binary link should be AMD instead of ARM #2250

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Windows binary link should be AMD instead of ARM #2250

merged 2 commits into from
Oct 16, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Oct 10, 2023

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Fix #2247

@yahavi yahavi added the ignore for release Automatically generated release notes label Oct 10, 2023
@yahavi yahavi requested a review from Or-Geva October 10, 2023 09:26
@yahavi yahavi self-assigned this Oct 10, 2023
@yahavi yahavi requested a review from eyalbe4 October 15, 2023 11:05
@yahavi yahavi merged commit 2225072 into jfrog:dev Oct 16, 2023
10 of 11 checks passed
@yahavi yahavi deleted the fix-download-link branch October 16, 2023 13:58
@yahavi yahavi linked an issue Oct 17, 2023 that may be closed by this pull request
Windows binary is actually "AMD64" and/or "ARM-64" #2247
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

@Or-Geva Or-Geva Awaiting requested review from Or-Geva

Assignees

@yahavi yahavi

Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows binary is actually "AMD64" and/or "ARM-64"
2 participants
@yahavi @eyalbe4