Add detailed negative cases

jet · Mar 8, 2020 · ec133cd · ec133cd
1 parent 6f2e0d1
commit ec133cd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/FsCodec.SystemTextJson/TypeSafeEnumConverter.fs b/src/FsCodec.SystemTextJson/TypeSafeEnumConverter.fs
@@ -14,7 +14,7 @@ module TypeSafeEnum =
 
     let tryParseT (t : Type) (str : string) =
         match Union.tryGetUnion t with
-        | None -> invalidArg "t" "Type must be a Union."
+        | None -> invalidArg "t" "Type must be a FSharpUnion."
         | Some u ->
             u.cases
             |> Array.tryFindIndex (fun case -> case.Name = str)

diff --git a/tests/FsCodec.SystemTextJson.Tests/TypeSafeEnumConverterTests.fs b/tests/FsCodec.SystemTextJson.Tests/TypeSafeEnumConverterTests.fs
@@ -3,6 +3,7 @@ module FsCodec.SystemTextJson.Tests.TypeSafeEnumConverterTests
 open FsCodec.SystemTextJson
 open System
 open System.Collections.Generic
+open System.Text.Json
 open Swensen.Unquote
 open Xunit
 
@@ -15,6 +16,12 @@ let [<Fact>] happy () =
     test <@ None = TypeSafeEnum.tryParse<Outcome> "Wat" @>
     raises<KeyNotFoundException> <@ TypeSafeEnum.parse<Outcome> "Wat" @>
 
+    let optionsWithOutcomeConverter = Options.Create(TypeSafeEnumConverter<Outcome>())
+    test <@ Joy = Serdes.Deserialize("\"Joy\"", optionsWithOutcomeConverter) @>
+    test <@ Some Joy = Serdes.Deserialize("\"Joy\"", optionsWithOutcomeConverter) @>
+    raises<KeyNotFoundException> <@ Serdes.Deserialize<Outcome>("\"Confusion\"", optionsWithOutcomeConverter) @>
+    raises<JsonException> <@ Serdes.Deserialize<Outcome> "1" @>
+
 let [<Fact>] sad () =
     raises<ArgumentException> <@ TypeSafeEnum.tryParse<string> "Wat" @>
     raises<ArgumentException> <@ TypeSafeEnum.toString "Wat" @>
@@ -35,4 +42,5 @@ let [<Fact>] fallBackExample () =
     test <@ Joy = Serdes.Deserialize<OutcomeWithOther> "\"Joy\"" @>
     test <@ Some Other = Serdes.Deserialize<OutcomeWithOther option> "\"Wat\"" @>
     test <@ Other = Serdes.Deserialize<OutcomeWithOther> "\"Wat\"" @>
+    raises<JsonException> <@ Serdes.Deserialize<OutcomeWithOther> "1" @>
     test <@ Seq.forall (fun (x,y) -> x = y) <| Seq.zip [Joy; Other] (Serdes.Deserialize "[\"Joy\", \"Wat\"]") @>