-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jest-config): add support for preset
written in ESM
#11200
Conversation
I could only make unit test for happy path. I couldn't make unit test for validating these cases
|
Codecov Report
@@ Coverage Diff @@
## master #11200 +/- ##
==========================================
- Coverage 64.29% 64.26% -0.03%
==========================================
Files 308 308
Lines 13484 13490 +6
Branches 3287 3288 +1
==========================================
+ Hits 8669 8670 +1
- Misses 4106 4111 +5
Partials 709 709
Continue to review full report at Codecov.
|
that's valid if |
Thanks !, I've added this case to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@ahnpnl running |
Sure! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Related to #11167
.cjs
,.mjs
to the supported extensions forpreset
as well as logic to load them, with.mjs
for ESM preset and.cjs
for CommonJS presetnormalize.test.ts
as well as fix some ts type errors.Test plan
Added unit tests for happy path
Added e2e tests