Allow fail to work in try/catch

jest-community · Oct 9, 2023 · d0474ee · d0474ee
1 parent 1f88101
commit d0474ee
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 10 deletions.
diff --git a/src/matchers/fail.js b/src/matchers/fail.js
@@ -1,4 +1,5 @@
 export function fail(_, message) {
+  this.dontThrow();
   return {
     pass: false,
     message: () => (message ? message : 'fails by .fail() assertion'),

diff --git a/test/matchers/__snapshots__/fail.test.js.snap b/test/matchers/__snapshots__/fail.test.js.snap
diff --git a/test/matchers/fail.test.js b/test/matchers/fail.test.js
@@ -3,11 +3,18 @@ import * as matcher from 'src/matchers/fail';
 expect.extend(matcher);
 
 describe('.fail', () => {
-  test('fails without message', () => {
-    expect(() => expect().fail()).toThrowErrorMatchingSnapshot();
+  xtest('fails without message', () => {
+    expect().fail(); // This should fail!
   });
-  test('fails with message', () => {
-    expect(() => expect().fail("This shouldn't fail!")).toThrowErrorMatchingSnapshot();
+  xtest('fails with message', () => {
+    expect().fail('This should fail!');
+  });
+  xtest('fails when invoked in a try/catch', () => {
+    try {
+      expect().fail();
+    } catch (error) {
+      expect('this assertion').toBe('not checked');
+    }
   });
 });
 
@@ -16,6 +23,6 @@ describe('.not.fail', () => {
     expect().not.fail();
   });
   test('does not fail with message', () => {
-    expect().not.fail('this should fail!');
+    expect().not.fail('this should not fail!');
   });
 });