Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a single ragged list from f_step in JAX mode #22

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

jessegrabowski
Copy link
Owner

@jessegrabowski jessegrabowski commented Aug 2, 2024

simulate was failing when mode="JAX" because the f_step function was returning two ragged lists instead of just one.

Also adds tests for simulate in JAX mode


📚 Documentation preview 📚: https://cge-modeling--22.org.readthedocs.build/en/22/

Add JAX mode tests for `test_solvers_agree`
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.94%. Comparing base (d6309ef) to head (fa856b6).

Files Patch % Lines
cge_modeling/__init__.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   66.30%   68.94%   +2.63%     
==========================================
  Files          17       17              
  Lines        2698     2708      +10     
==========================================
+ Hits         1789     1867      +78     
+ Misses        909      841      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessegrabowski jessegrabowski merged commit a0acfc3 into main Aug 2, 2024
4 of 5 checks passed
@jessegrabowski jessegrabowski deleted the jax-euler-fix branch August 2, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant