Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements to support Python 3.11 and M1 Macs #401

Closed
wants to merge 1 commit into from

Conversation

glennfu
Copy link

@glennfu glennfu commented May 11, 2023

This will allow pip install -e . and pytest to succeed on an M1 Mac running Python 3.11.3. I also tested running the build on my local bot folder and clicked around a bit on the uvicorn site. I also tested importing BTC and ETH from Binance US, as well as running the example GoldenCross indicator. Everything seems to work well!

The only downside here in the requirements is that dydx-v3-python is tied to a pull request that hasn't yet been accepted. I couldn't find any way to get the requirements to build in this scenario without it.

@glennfu
Copy link
Author

glennfu commented May 11, 2023

As an extra note, I was motivated to work on this because the current MacOS instructions mention numba being optional and installing openblas and scipy instead. I followed the directions, successfully installed openblas and scipy, but my build attempts, both from pip install jesse, as well as building from source, didn't seem to treat numba as optional and would fail to build. So I found that there's a newer version of numba that builds successfully on my M1 Mac with Python 3.11.

@saleh-mir
Copy link
Member

It's good news about numba. But to merge this we have to wait for DYDX PR to merge as well.

@saleh-mir
Copy link
Member

@cryptocoinserver was there any other reason why we couldn't support python 3.10?

@cryptocoinserver
Copy link
Collaborator

Not that I remember. Mainly numba did block.

@glennfu
Copy link
Author

glennfu commented May 19, 2023

It's good news about numba. But to merge this we have to wait for DYDX PR to merge as well.

I wonder if we should be concerned about that. Last activity on the project was January 27th.

@saleh-mir
Copy link
Member

If they don't do it in the coming months I will have to rewrite my code to not use it.

@stale
Copy link

stale bot commented Jul 24, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No recent activity. label Jul 24, 2023
@stale stale bot closed this Jul 31, 2023
@saleh-mir saleh-mir reopened this Aug 24, 2023
@stale stale bot removed the stale No recent activity. label Aug 24, 2023
@movy
Copy link
Contributor

movy commented Sep 3, 2023

Will this be merged and released any time soon? More and more issues supporting python 3.9 afloat. Update to the live module is also welcome.

@saleh-mir
Copy link
Member

I'm working on this and will included in the next release

@saleh-mir
Copy link
Member

This is now done in the recent release. I took heavy inspiration from this pull request. Thank you for submitting it

@saleh-mir saleh-mir closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants