-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update requirements to support Python 3.11 and M1 Macs #401
Conversation
As an extra note, I was motivated to work on this because the current MacOS instructions mention |
It's good news about numba. But to merge this we have to wait for DYDX PR to merge as well. |
@cryptocoinserver was there any other reason why we couldn't support python 3.10? |
Not that I remember. Mainly numba did block. |
I wonder if we should be concerned about that. Last activity on the project was January 27th. |
If they don't do it in the coming months I will have to rewrite my code to not use it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Will this be merged and released any time soon? More and more issues supporting python 3.9 afloat. Update to the live module is also welcome. |
I'm working on this and will included in the next release |
This is now done in the recent release. I took heavy inspiration from this pull request. Thank you for submitting it |
This will allow
pip install -e .
andpytest
to succeed on an M1 Mac running Python 3.11.3. I also tested running the build on my local bot folder and clicked around a bit on the uvicorn site. I also tested importing BTC and ETH from Binance US, as well as running the example GoldenCross indicator. Everything seems to work well!The only downside here in the requirements is that
dydx-v3-python
is tied to a pull request that hasn't yet been accepted. I couldn't find any way to get the requirements to build in this scenario without it.